| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Neha Sharma <neha(dot)sharma(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb |
| Date: | 2021-04-19 07:26:18 |
| Message-ID: | CAAJ_b96aKwGj6QJ6M9QNPR1s7pn=4CQ2P6BRagv9y2ACeRmNng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 19, 2021 at 12:25 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Apr 09, 2021 at 06:45:45PM -0400, Alvaro Herrera wrote:
> > We forgot this patch earlier in the commitfest. Do people think we
> > should still get it in on this cycle? I'm +1 on that, since it's a
> > safety feature poised to prevent more bugs than it's likely to
> > introduce.
>
> No objections from here to do that now even after feature freeze. I
> also wonder, while looking at that, why you don't just remove the last
> call within src/backend/catalog/heap.c. This way, nobody is tempted
> to use RelationOpenSmgr() anymore, and it could just be removed from
> rel.h.
Agree, did the same in the attached version, thanks.
Regards,
Amul
P.S. commitfest entry https://commitfest.postgresql.org/33/3084/
| Attachment | Content-Type | Size |
|---|---|---|
| v2_Add-RelationGetSmgr-inline-function.patch | application/octet-stream | 34.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-04-19 07:48:34 | Re: Replication slot stats misgivings |
| Previous Message | David Rowley | 2021-04-19 07:08:36 | Re: Performance Evaluation of Result Cache by using TPC-DS |