From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | sulamul(at)gmail(dot)com |
Cc: | michael(at)paquier(dot)xyz, alvherre(at)alvh(dot)no-ip(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, noah(at)leadboat(dot)com, neha(dot)sharma(at)enterprisedb(dot)com, amitlangote09(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb |
Date: | 2021-04-19 08:35:52 |
Message-ID: | 20210419.173552.106077363675220541.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Mon, 19 Apr 2021 12:56:18 +0530, Amul Sul <sulamul(at)gmail(dot)com> wrote in
> On Mon, Apr 19, 2021 at 12:25 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Fri, Apr 09, 2021 at 06:45:45PM -0400, Alvaro Herrera wrote:
> > > We forgot this patch earlier in the commitfest. Do people think we
> > > should still get it in on this cycle? I'm +1 on that, since it's a
> > > safety feature poised to prevent more bugs than it's likely to
> > > introduce.
> >
> > No objections from here to do that now even after feature freeze. I
> > also wonder, while looking at that, why you don't just remove the last
> > call within src/backend/catalog/heap.c. This way, nobody is tempted
> > to use RelationOpenSmgr() anymore, and it could just be removed from
> > rel.h.
>
> Agree, did the same in the attached version, thanks.
+ smgrwrite(RelationGetSmgr(index), INIT_FORKNUM, BLOOM_METAPAGE_BLKNO,
(char *) metapage, true);
- log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM,
+ log_newpage(&(RelationGetSmgr(index))->smgr_rnode.node, INIT_FORKNUM,
At the log_newpage, index is guaranteed to have rd_smgr. So I prefer
to leave the line alone.. I don't mind other sccessive calls if any
since what I don't like is the notation there.
> P.S. commitfest entry https://commitfest.postgresql.org/33/3084/
Isn't this a kind of open item?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2021-04-19 08:46:45 | Re: Doubt with [ RANGE partition with TEXT datatype ] |
Previous Message | Amit Kapila | 2021-04-19 08:32:59 | Re: Table refer leak in logical replication |