| From: | amul sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [POC] hash partitioning |
| Date: | 2017-07-03 11:12:11 |
| Message-ID: | CAAJ_b96Rn+mg+16opC-v1N9K6i1uk88JT30zs9mO7OHmDE-z8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 23, 2017 at 11:19 AM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> On Fri, 23 Jun 2017 13:41:15 +0900
> Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
>> On Tue, 6 Jun 2017 13:03:58 +0530
>> amul sul <sulamul(at)gmail(dot)com> wrote:
>>
>>
>> > Updated patch attached.
>>
>> I looked into the latest patch (v13) and have some comments
>> althogh they might be trivial.
>
> One more comment:
>
> + if (spec->remainder < 0)
> + ereport(ERROR,
> + (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
> + errmsg("remainder for hash partition must be a non-negative integer")));
>
> The value of remainder is defined as Iconst in gram.y, so it never be negative.
> Hence, I think this check is not necessary or Assert is enough.
>
Make sense, fixed this as well in the v14 patch. Thanks again.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2017-07-03 11:13:23 | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Previous Message | amul sul | 2017-07-03 11:09:51 | Re: [POC] hash partitioning |