| From: | amul sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] ALTER SYSTEM READ ONLY |
| Date: | 2020-06-19 03:58:53 |
| Message-ID: | CAAJ_b96Lb+RXNiZ3=iikVw8DuV_xs=Ka1N9hwxMF46X+yArZyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2020 at 8:23 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Jun 18, 2020 at 5:55 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > For buffer replacement, many-a-times we have to also perform
> > XLogFlush, what do we do for that? We can't proceed without doing
> > that and erroring out from there means stopping read-only query from
> > the user perspective.
>
> I think we should stop WAL writes, then XLogFlush() once, then declare
> the system R/O. After that there might be more XLogFlush() calls but
> there won't be any new WAL, so they won't do anything.
>
Yeah, the proposed v1 patch does the same.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-06-19 04:03:58 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Fujii Masao | 2020-06-19 03:56:16 | Re: POC and rebased patch for CSN based snapshots |