| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Deduplicate code updating ControleFile's DBState. |
| Date: | 2021-11-29 04:48:59 |
| Message-ID: | CAAJ_b96B_AHfD2-=fPiny0Hfeh62bQa7aFJe63K7vfcbeHMT+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 29, 2021 at 10:12 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Nov 29, 2021 at 09:28:23AM +0530, Bharath Rupireddy wrote:
> > In that case, why can't we inline UpdateControlFile to avoid the
> > function call cost? Do you see any issues with it?
>
> This routine is IMO not something worth bothering about.
>
> > BTW, the v6 patch proposed by Amul at [1], looks good to me.
>
> Yes, I have no problems with this part, so done.
Thank you, Michael.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2021-11-29 05:04:06 | tweak to a few index tests to hits ambuildempty() routine. |
| Previous Message | Peter Smith | 2021-11-29 04:44:52 | Re: row filtering for logical replication |