| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Noah Misch <noah(at)leadboat(dot)com>, Neha Sharma <neha(dot)sharma(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb |
| Date: | 2021-07-13 03:48:05 |
| Message-ID: | CAAJ_b958_qxojDEZOb6wMOcqhJqgwwBEMEf-VTd9+EVevrPgLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks a lot Tom.
On Tue, Jul 13, 2021 at 2:37 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amul Sul <sulamul(at)gmail(dot)com> writes:
> > [ v5_Add-RelationGetSmgr-inline-function.patch ]
>
> Pushed with minor cosmetic adjustments.
>
> RelationCopyStorage() kind of gives me the willies.
> It's not really an smgr-level function, but we call it
> everywhere with smgr pointers that belong to relcache entries:
>
> /* copy main fork */
> - RelationCopyStorage(rel->rd_smgr, dstrel, MAIN_FORKNUM,
> + RelationCopyStorage(RelationGetSmgr(rel), dstrel, MAIN_FORKNUM,
> rel->rd_rel->relpersistence);
>
> So that would fail hard if a relcache flush could occur inside
> that function. It seems impossible today, so I settled for
> just annotating the function to that effect. But it won't
> surprise me a bit if somebody breaks it in future due to not
> having read/understood the comment.
>
> regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2021-07-13 04:00:49 | Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors |
| Previous Message | Peter Smith | 2021-07-13 03:25:48 | Re: row filtering for logical replication |