Re: using an end-of-recovery record in all cases

From: Amul Sul <sulamul(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: using an end-of-recovery record in all cases
Date: 2021-10-05 16:41:10
Message-ID: CAAJ_b94RidhUAZT+KUCRsC6t5uKmGWBUPR+O95F8eEw9UVfD2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 5 Oct 2021 at 9:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Oct 5, 2021 at 7:44 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > I was trying to understand the v1 patch and found that at the end
> > RequestCheckpoint() is called unconditionally, I think that should
> > have been called if REDO had performed,
>
> You're right. But I don't think we need an extra variable like this,
> right? We can just test InRecovery?

No, InRecovery flag get cleared before this point. I think, we can use
lastReplayedEndRecPtr what you have suggested in other thread.

Regards,
Amul
--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-10-05 16:41:27 Re: BUG #17212: pg_amcheck fails on checking temporary relations
Previous Message Mark Dilger 2021-10-05 16:38:03 Re: Role Self-Administration