| From: | amul sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove unnecessary flag has_null from PartitionBoundInfoData |
| Date: | 2017-06-12 10:20:49 |
| Message-ID: | CAAJ_b94AkEzcx+12ySCnbMDX7=UdF4BjnoBGfMQbB0RNSTo3Ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 17, 2017 at 10:22 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
[...]
> I committed this with fixes for those issues, plus I renamed the macro
> to partition_bound_accepts_nulls, which I think is more clear.
>
partition_bound_accepts_nulls() will alway yield true for a range
partitioning case, because in RelationBuildPartitionDesc, we forgot to
set boundinfo->null_index to -1.
The attached patch fixes that.
Regards,
Amul
| Attachment | Content-Type | Size |
|---|---|---|
| set_boundinfo-null_index.patch | application/octet-stream | 826 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Kondratov | 2017-06-12 10:52:17 | Re: GSOC'17 project introduction: Parallel COPY execution with errors handling |
| Previous Message | Amit Kapila | 2017-06-12 10:19:48 | Re: Broken hint bits (freeze) |