| From: | Harrison Booth <harrisontbooth(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_upgrade: handle failed nonblocking connects on Windows |
| Date: | 2026-10-16 18:28:35 |
| Message-ID: | CAAH-eSWrgy0WtNyM-qPsTTwGmJL7Yy-mUcpGwRiPNDNG8OSaNA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I agree here. v2 (attached) passes a separate exception set through
select_loop() and checks it on all platforms. The existing EINTR loop
is unchanged.
All seven Windows assertions pass on native x64 and ARM64. Linux
passes eight existing upgrade scripts plus EINTR,
exceptional-readiness & refused-connect controls.
I also tested it alongside the --initdb v8 proposal on 89e06d while
retaining the test registrations. It applies to 1d45c5d.
Best,
Harrison
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_upgrade-handle-failed-nonblocking-connects.patch | text/x-patch | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harrison Booth | 2026-10-16 19:01:21 | Re: [PATCH] Fix orphaned backend processes on Windows using Job Objects |
| Previous Message | Masahiko Sawada | 2026-10-16 18:11:36 | Re: Reject COPY TO of unlogged relations during recovery |