Re: [PATCH v3] Fix pg_basebackup long-path test on Windows

From: harrisontbooth(at)gmail(dot)com
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v3] Fix pg_basebackup long-path test on Windows
Date: 2026-10-12 23:37:29
Message-ID: CAAH-eSWWaHCCs6PjdPZSG+OKLMdGL2BMR89fa5YyELJR=eQaLw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is v3 rebased on master at 8e82d6610e7. It retains the $!
detail you requested in v2 and creates the directory through the short
side of the Windows junction. There are no further test-logic changes.

Full ARM64 and x64 builds passed. The refreshed pg_basebackup suite
passed all 151 subtests on both native ARM64 and x64 under ARM64
emulation. Both runs emitted directory-cleanup warnings but passed all
assertions.

Could you take another look when you have a chance?

A separate GitHub-hosted Windows x64 build and all nine test groups
passed with all three patches applied. The pg_basebackup suite passed
all 152 subtests on the GitHub Windows x64 runner.

Best,
Harrison

Attachment Content-Type Size
v3-0001-Fix-pg_basebackup-long-path-test-on-Windows.patch text/x-diff 1.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message harrisontbooth 2026-10-12 23:37:31 Re: [PATCH v2] meson: Support ECPG tests in runnable cross builds
Previous Message harrisontbooth 2026-10-12 23:37:27 Re: [PATCH v2] Fix races in Windows pthread emulation