[PATCH] pg_test_fsync: close Windows alarm thread handles

From: harrisontbooth(at)gmail(dot)com
To: pgsql-hackers(at)postgresql(dot)org
Cc: Sehrope Sarkuni <sehrope(at)jackdb(dot)com>
Subject: [PATCH] pg_test_fsync: close Windows alarm thread handles
Date: 2026-10-13 14:03:30
Message-ID: CAAH-eSVFy2GySdYEAtd9Wp=Swka0TzZGkw2VrO8GTaq3ndcikQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is a follow-up to Sehrope's CF7218 timer fix - close each
created alarm-thread handle. Closing the handle leaves the callback
running.

This is a dependent supplement. Apply the included CreateThread
failure-check prerequisite, then this patch, on master 8e82d6610e7.
The prerequisite credits Sehrope; it contains only his timer fix.

Source-extracted probes on native ARM64 and emulated x64 show 200
retained handles before the change and none afterward, with all 200
callbacks completing. The actual pg_test_fsync -s 1 benchmark sequence
also passes on both targets in the combined integration builds.
Formatting and independent reviews pass.

The measurements establish handle cleanup and callback completion;
they aren't performance benchmarks.

Let me know your thoughts.

Best,

Harrison

Attachment Content-Type Size
LOCAL-PREREQUISITE-CF7218-timer-failure-check.patch text/x-diff 1002 bytes
0001-Close-the-Windows-pg_test_fsync-timer-thread-handle.patch text/x-diff 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-13 14:23:26 Re: [PG19] Stale state after the join removal restart gives wrong results
Previous Message Sami Imseih 2026-10-13 13:50:31 Re: pgstat: Flush some statistics within running transactions, take 2