| From: | harrisontbooth(at)gmail(dot)com |
|---|---|
| To: | Bohyun Lee <bohyun(dot)lee(at)databricks(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically |
| Date: | 2026-10-14 05:58:50 |
| Message-ID: | CAAH-eSUhcC4hsgAAeS6Mm0zmtwA1zXovAieJKA8pZCPeabpQ7A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I rebased the Windows test cleanup onto your branch at 170df44c. It
detaches the two test-owned WAL junctions only after the test passes
and preserves them for failed tests or PG_TEST_NOCLEAN.
The full test passed on native ARM64 and emulated x64. I also verified
both architectures retain the junctions after the existing long-path
failures and with PG_TEST_NOCLEAN=0. Those path failures reproduce
without this cleanup change.
The attached mbox contains your five branch commits unchanged,
followed by the cleanup supplement. It applies with git am on the
recorded author base and master 6b3f8857; runtime testing used the
recorded author-based builds.
Let me know if this cleanup approach works for you.
Best,
Harrison
| Attachment | Content-Type | Size |
|---|---|---|
| CF7025-author170df44c-with-cleanup-v5.patch | text/x-patch | 172.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-10-14 06:02:29 | Re: "failed to build any N-way joins" from a five-relation query |
| Previous Message | Zhijie Hou | 2026-10-14 04:58:42 | Re: Proposal: Conflict log history table for Logical Replication |