Re: Support logical replication of DDLs

From: Zheng Li <zhengli10(at)gmail(dot)com>
To: "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2023-03-17 15:40:56
Message-ID: CAAD30UJQ2PnNUk3qBacfTDa9eDcrRC35HxqkbYfV1C8prNk0uA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Fri, Mar 17, 2023 at 10:49 AM Takamichi Osumi (Fujitsu)
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> Hi
>
> On Tuesday, March 14, 2023 1:17 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> > I found out that the option ONLY was not parsed in the "CREATE INDEX"
> > command, for eg: CREATE UNIQUE INDEX ... ON ONLY table_name ...
> >
> > I've fixed this in patch 0002.
> FYI, cfbot reports a failure of v80 on linux [1]. Could you please check ?
>
>
> [17:39:49.745] ============== running regression test queries ==============
> [17:39:49.745] test test_ddl_deparse ... ok 27 ms
> [17:39:49.745] test create_extension ... ok 60 ms
> [17:39:49.745] test create_schema ... ok 28 ms
> [17:39:49.745] test aggregate ... ok 19 ms
> [17:39:49.745] test create_table ... FAILED 245 ms
> [17:39:49.745] test constraints ... FAILED 420 ms
> [17:39:49.745] test alter_table ... FAILED 448 ms
> [17:39:49.745] ============== shutting down postmaster ==============
> [17:39:49.745]
> [17:39:49.745] ======================
> [17:39:49.745] 3 of 7 tests failed.
> [17:39:49.745] ======================
> [17:39:49.745]
> [17:39:49.745] The differences that caused some tests to fail can be viewed in the
> [17:39:49.745] file "/tmp/cirrus-ci-build/src/test/modules/test_ddl_deparse_regress/regression.diffs". A copy of the test summary that you see
> [17:39:49.745] above is saved in the file "/tmp/cirrus-ci-build/src/test/modules/test_ddl_deparse_regress/regression.out".
>

Hi,

I've updated the failing test output in the attached patch set.

Regards,
Zane

Attachment Content-Type Size
v80-0001-Infrastructure-to-support-DDL-deparsing.patch application/octet-stream 44.2 KB
v80-0002-Functions-to-deparse-Table-DDL-commands.patch application/octet-stream 131.3 KB
v80-0005-DDL-messaging-infrastructure-for-DDL-replication.patch application/octet-stream 41.5 KB
v80-0003-Support-DDL-deparse-of-the-rest-commands.patch application/octet-stream 205.2 KB
v80-0004-Introduce-the-test_ddl_deparse_regress-test-module.patch application/octet-stream 919.1 KB
v80-0007-Document-DDL-replication-and-DDL-deparser.patch application/octet-stream 40.6 KB
v80-0006-Support-DDL-replication.patch application/octet-stream 200.4 KB
v80-0008-Allow-replicated-objects-to-have-the-same-owner-from.patch application/octet-stream 59.2 KB

In response to

Browse pgsql-general by date

  From Date Subject
Next Message jian he 2023-03-17 16:42:11 Re: src/test/examples/testlibpq2.c where the HAVE_SYS_SELECT_H is defined.
Previous Message Takamichi Osumi (Fujitsu) 2023-03-17 14:49:37 RE: Support logical replication of DDLs

Browse pgsql-hackers by date

  From Date Subject
Next Message gkokolatos 2023-03-17 15:43:58 Re: Add LZ4 compression in pg_dump
Previous Message Önder Kalacı 2023-03-17 15:28:46 Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL