| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Aditya Gollamudi <adigollamudi(at)gmail(dot)com>, cca5507 <cca5507(at)qq(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor refactor of the code in ExecScanExtended() |
| Date: | 2026-03-25 01:53:55 |
| Message-ID: | CAAAe_zDyq-Yg-xL8FSNaeneSXmesFs6JefxNJo2coQQjP3RLcQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
2026년 1월 19일 (월) PM 1:51, Aditya Gollamudi <adigollamudi(at)gmail(dot)com>님이 작성:
> On Sun, Jan 18, 2026 at 7:31 PM cca5507 <cca5507(at)qq(dot)com> wrote:
>
>> Hi,
>>
>> The current code:
>>
>> if (!qual && !projInfo)
>> {
>> ResetExprContext(econtext);
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>> }
>>
>> ResetExprContext(econtext);
>>
>> The following format might be simpler:
>>
>> ResetExprContext(econtext);
>>
>> if (!qual && !projInfo)
>> return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
>>
>> Attach a patch to do this.
>>
>> --
>> Regards,
>> ChangAo Chen
>>
>> Hi,
>
> +1, seems like a simple refactor.
> Tests are passing locally for me!
>
> - Adi Gollamudi
>
+1, agreed.
The refactored version is cleaner and easier to read by moving
ResetExprContext() before the early return,
eliminating the duplicated logic.
Best regards,
Henson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-03-25 01:55:29 | Re: VACUUM FULL, CLUSTER, and REPACK block on other sessions' temp tables |
| Previous Message | Michael Paquier | 2026-03-25 01:50:53 | Re: raise ERROR between EndPrepare and PostPrepare_Locks causes ROLLBACK 2pc PAINC |