Re: [PATCH] Fix quotation logic for unreserved keywords in window specifications

From: Henson Choi <assam258(at)gmail(dot)com>
To: Kwangwon Seo <anchovyseo(at)gmail(dot)com>
Cc: Tatsuo Ishii <ishii(at)postgresql(dot)org>, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix quotation logic for unreserved keywords in window specifications
Date: 2026-08-26 23:37:39
Message-ID: CAAAe_zDGrbc9Je+qv6FSjj1KyLWKyrnNNBi5iwT0_X1pE6LDQA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Kwangwon,

Thanks for v3. All three points are addressed, and I have checked the
list once more against the grammar: of the nine tokens sharing IDENT's
precedence, only the four that can begin a clause in that position --
PARTITION, RANGE, ROWS and GROUPS -- are rejected bare; the rest
round-trip unquoted, so the four in appendWindowRefName() are exactly
the set that needs quoting. The new window.sql cases pass here.

Best regards,
Henson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2026-08-26 23:39:10 Re: MERGE/SPLIT PARTITIONS issues/questions
Previous Message Joao Foltran 2026-08-26 23:31:36 Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation