| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | shinsj4653(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, vik(at)postgresfriends(dot)org, pgsql-hackers(at)postgresql(dot)org, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-07-21 02:08:34 |
| Message-ID: | CAAAe_zD7RPD369sOwCzyWRvMwcEHWmiwVveSm7P0YStcb0HdUw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tatsuo,
Thanks for the 2015-2026 review. Just the three you flagged:
> ... it will make it hard to call the function from R010
> implementation because MATCH_RECOGNIZE node surely will not have
> WindowClause node.
Agreed -- reusability for R010 matters more. I'll keep the explicit
arguments rather than the WindowClause and revise 2016 so
buildRPRPattern() just walks defineClause for the DEFINE names.
> I think we should not include following patch in our patch set. That
> has nothing to do with RPR.
You're right, it doesn't belong with RPR. I'll remove the two
follow-up commits and drop it from 2019.
> There's no instance in PostgreSQL code which uses
> pg_attribute_unused() with function arguments for debugging purpose.
OK. I will remove the pg_attribute_unused().
Best regards,
Henson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | JoongHyuk Shin | 2026-07-21 02:12:23 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |
| Previous Message | Ian Lawrence Barwick | 2026-07-21 01:48:44 | Re: [PATCH] Add pg_get_event_trigger_ddl() function |