| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: Heads Up: cirrus-ci is shutting down June 1st |
| Date: | 2026-06-29 00:25:51 |
| Message-ID: | CAAAe_zBJMKLinHZvTb4kJxXxD_j+zgHzxsP8mc55GmRHS7vWqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Since cfbot keeps coming up here, a quick bug report.
cfbot treats a .tgz attachment as a patch even when the archive has no
patch inside. It then applies nothing, tests plain master, and reports
green -- so a real patch posted earlier drops out of testing and the CF
entry shows a false green.
Live example: CF 5802 (Unicode Normalization). The last real patchset
is v11. My next message attached coverage.tgz (a gcov HTML report, not
a patch); cfbot took that as the latest submission and has been testing
master ever since. That's the reproducer -- and the reason 5802 looks
"stale/merged" on the dashboard when it isn't.
Suggested fix: only treat an attachment as a patch if it's a
.patch/.diff, or an archive containing one; otherwise ignore it and fall
back to the last attachment set that had patches.
Regards,
Henson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-06-29 00:28:00 | Re: Handle concurrent drop when doing whole database vacuum |
| Previous Message | Michael Paquier | 2026-06-29 00:13:35 | Re: Handle concurrent drop when doing whole database vacuum |