Re: Row pattern recognition

From: Henson Choi <assam258(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-06-02 14:11:05
Message-ID: CAAAe_zAv0FZQfdjAX05QpE5qtdQQUrqEfZgOZRb1P9Qincircg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tatsuo,

Catching up on today's notes -- all straightforward, so I'm folding them
into one reply.

> I'd prefer (3). Yes, I agree that 240 pattern variables is enough.

Then (3) it is -- and with Jian on the same choice, that closes it. I'll
go ahead with it. Since it's a narrowing it's only free pre-release, so
it goes in the v48 core rather than a later follow-up.

> static void
> nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext
*ctx,
> int64 currentPos)
>
> This function does not have a forward declaration. Moreover, it is put
> in the "API exposed to nodeWindowAgg.c" section. [...] I suggest to add
> a forward declaration for it and move it before "API exposed to
> nodeWindowAgg.c" section.

Agreed -- that was just an oversight. I'll add the forward declaration
and move it out of the API-exposed section.

> nocfbot-0025-...:55:+ (errcode(ERRCODE_WINDOWING_ERROR),
> Maybe this is the only one worth to look into?

Right -- I'll update 0025 in the next posting.

Thanks,
Henson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-06-02 14:13:45 Re: [RFC PATCH v2 RESEND 10/10] umbra: add patch 9 compactor framework and non-interference policy
Previous Message Nathan Bossart 2026-06-02 14:08:12 Re: problems with toast.* reloptions