| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org>, jian(dot)universality(at)gmail(dot)com |
| Cc: | zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-05-05 09:15:29 |
| Message-ID: | CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC=sGUg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tatsuo, Jian,
Both coding-style items from Jian's review will be addressed and
included in the next patch series.
> 1. We need to add trailing commas to enum definitions. See
> >
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7
>
> I forgot that. Thanks for reminding.
>
Three enum types introduced by the patch lack a trailing comma on the
last enumerator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.
All three will be corrected in the next series.
> > + (errcode(ERRCODE_SYNTAX_ERROR),
> > The leading parenthesis is optional and can be removed, fewer
> > parentheses are always better.
> > See related discussion:
> > https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql
>
> Right. I will review all other patches.
The outer-parentheses pattern appears in 17 ereport() calls in
parse_rpr.c and 2 in optimizer/plan/rpr.c. All 19 sites will be
cleaned up in the next series.
Jian, I will review your other patches as well.
Best,
Henson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2026-05-05 09:42:28 | Re: Row pattern recognition |
| Previous Message | Andrey Borodin | 2026-05-05 09:07:17 | Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race |