Re: [DEPARSE] Operators on ROW() constructors read back as row comparisons

From: Henson Choi <assam258(at)gmail(dot)com>
To: "crprashant(at)hotmail(dot)com" <crprashant(at)hotmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] Operators on ROW() constructors read back as row comparisons
Date: 2026-10-23 01:58:29
Message-ID: CAAAe_zAgWbv5+Lu3rvTjuEWyxLNNdw74dE2NpVC+aHKzECY1Qg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Prashant,

> One question: with the ruleutils.c part gone, what is intended for
> the back branches? A parser-side fix changes nothing for objects
> already stored in a back-branch database, and I could not tell from
> the v3 email whether backpatching is planned.

The ruleutils.c change (v2-0004) was the part meant for the back
branches, for exactly the reason you give: a parser-side fix cannot
help trees that are already stored. Tom was not concerned about
those trees, given that there have been no field complaints, so I
dropped it in v3.

Whether v3 goes into the back branches without it, I leave to the
committer.

Thanks for the careful review and testing.

By the way, neither of your two reviews reached my mailbox, so I read
them in the archive. I suppose that is because they were posted
through the CommitFest app rather than sent as mail to the list. If
you reply by mail next time, I will see it sooner.

Best regards,
Henson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-10-23 01:59:36 Re: Incremental backup can use a summary past a timeline switch
Previous Message Haibo Yan 2026-10-23 01:45:05 Re: [PATCH] Fix grouping-set nulling of variable-free grouping expressions