| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-02-05 00:46:06 |
| Message-ID: | CAAAe_zA=BDm=e04aNFYe3Az0CzPipK+HHzu1KGHiLOg+r_z8XQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tatsuo,
> Therefore, I believe it only makes sense to add explicit initialization
> > for nfaStatesActive and nfaContextsActive, since these are the only two
> > that release_partition() also explicitly resets.
>
> That makes sense.
>
Thank you for confirming.
> ## Proposal for consistency
> >
> > /* Initialize NFA free lists for row pattern matching */
> > winstate->nfaContext = NULL;
> > winstate->nfaContextTail = NULL;
> > winstate->nfaContextFree = NULL;
> > winstate->nfaStateFree = NULL;
> > winstate->nfaLastProcessedRow = -1;
> > winstate->nfaStatesActive = 0; // Add this
> > winstate->nfaContextsActive = 0; // Add this
> >
> > Would you like me to include this change in the next patch?
>
> Yes, please.
>
Done. Please see the attached patch.
Best regards,
Henson
| Attachment | Content-Type | Size |
|---|---|---|
| nfa_init_consistency.txt | text/plain | 887 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2026-02-05 00:51:10 | Re: Pasword expiration warning |
| Previous Message | Michael Paquier | 2026-02-05 00:40:58 | Re: Change checkpoint‑record‑missing PANIC to FATAL |