| From: | Zshengbin91 <zshengbin91(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | improve comments on CreateFunction returnsSet |
| Date: | 2025-12-25 03:05:15 |
| Message-ID: | CAA9n-n65zXceL-zD-v9S_ADuUrYagO6gotfob1pOMQjS5f-FGA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I'm using postgres, and I found a potentially ambiguous code comment in the
`CreateFunction` function. `returnsSet` is a boolean variable, and to be
consistent with the subsequent error message, I believe the comment should
be modified to match the error message. "reject ROWS if it's not
returnsSet" should be changed to "reject ROWS if it does not return a set"
Therefore, I've attached a patch to address this issue.
Thanks!
Br/Shengbin Zhao
| Attachment | Content-Type | Size |
|---|---|---|
| improve_comments_on_CreateFunction_returnSet.patch | text/plain | 624 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-25 03:12:07 | Trivial Fix: use palloc_array/repalloc_array for BufFile file arrays |
| Previous Message | Chao Li | 2025-12-25 02:40:02 | Re: Switch buffile.c/h to use pgoff_t |