|From:||Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>|
|To:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|Cc:||Tom Dunstan <tom(at)tomd(dot)cc>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: Allow auto_explain to log to NOTICE|
|Views:||Raw Message | Whole Thread | Download mbox|
On Wed, Jun 20, 2018 at 2:06 PM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 27 Apr 2018, at 04:24, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2018-04-27 11:52:18 +0930, Tom Dunstan wrote:
>>>> I'd argue this should contain the non-error cases. It's just as
>>>> reasonable to want to add this as a debug level or such.
>>> So all of warning, info, debug and debug1-5?
>> Yea. Likely nobody will ever use debug5, but I don't see a point making
>> that judgement call here.
> Did you have a chance to hack up a new version of the patch with Andres’ review
> comments? I’m marking this patch as Waiting on Author for now based on the
> feedback so far in this thread.
Here is an updated version of the patch. Setting this to "needs review".
I haven't added tests for auto_explain - I think that would be useful
but it's a separate project.
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Alvaro Herrera||2018-07-04 13:57:31||Re: Non-reserved replication slots and slot advancing|
|Previous Message||Jeff Janes||2018-07-04 13:17:32||Re: How to use public key file to encrypt data|