| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default |
| Date: | 2018-03-28 01:07:49 |
| Message-ID: | CAA8=A7_p3r4GiEV9=nbiwy8=skFTzRN2OSvLN+Un1gJLPwdusA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Mar 28, 2018 at 11:30 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2018-03-28 00:56:10 +0000, Andrew Dunstan wrote:
>> Fast ALTER TABLE ADD COLUMN with a non-NULL default
>
>> src/backend/executor/execExprInterp.c | 2 +-
>
> I bet this'll break JITed tuple deforming... We'll have to emit a call
> to the new slot missingattrs function, instead of using memset directly.
>
> Do you want to attempt to take care of it, or should I?
>
Please do. I guess I need to do some enabling of that in my test setup.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-28 01:10:31 | Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default |
| Previous Message | Andres Freund | 2018-03-28 01:00:53 | Re: pgsql: Fast ALTER TABLE ADD COLUMN with a non-NULL default |