Re: Re: A separate table level option to control compression

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, David Steele <david(at)pgmasters(dot)net>
Subject: Re: Re: A separate table level option to control compression
Date: 2019-04-05 13:10:31
Message-ID: CAA8=A78HaaebLZFHgLseVTLpumL46hHqee646279vt7LMp2vRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 5, 2019 at 2:58 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Apr 03, 2019 at 03:23:33PM +0900, Michael Paquier wrote:
> > It seems to me that c251336 should have done all those things from the
> > start... In other terms, isn't that a bug and something that we
> > should fix and back-patch? I'll begin a new thread about that to
> > catch more attention, with Simon and Andrew in CC.
>
> For what it's worth, I have dropped a new thread on the matter here:
> https://www.postgresql.org/message-id/20190403063759.GF3298@paquier.xyz
>
> It seems to me that it is sensible to conclude on the other thread
> first before acting on what is proposed here. As we are only a couple
> of days away from the feature freeze, are there any objections to mark
> this patch as returned with feedback?

Well, that would be a bit sad. ISTM if we conclude that the current
behaviour is a bug we could commit the current patch and backpatch a
fix to honor a lower toast_tuple_threshold. But yes, time is tight.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-04-05 14:01:25 Re: Failure in contrib test _int on loach
Previous Message Daniel Verite 2019-04-05 13:03:37 Re: Changes to pg_dump/psql following collation "C" in the catalog