Re: Time to put context diffs in the grave

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Time to put context diffs in the grave
Date: 2018-05-23 21:11:10
Message-ID: CAA8=A7-37KWv1VyTySvZuQTpocvPT-3qH03cxHaNSMPZQihXCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 23, 2018 at 5:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> OK, that's done. Now I think we can get rid of git-external-diff.
>
> I for one rely on that. I won't tell anyone else what kind of diff
> they have to read, but if you try to tell me what kind of diff I have
> to read, I'm going to complain.
>

OK, then given I have just removed all reference to it in the "Working
with Git" wiki page, maybe it needs some comments on how to use it
:-)

>> While we're about it, does anyone use make_diff any more? It seems
>> rather ancient and crufty.
>
> Not me, but judging from the README, possibly Bruce still uses it.
> In any case, is it hurting anything?
>

No, just being anally retentive. But then we saw recently how that can
be a good thing :-)

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-05-23 21:31:32 Re: PG11 jit failing on ppc64el
Previous Message Tom Lane 2018-05-23 21:10:07 Re: plperl fails with perl 5.28