From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Questions/Observations related to Gist vacuum |
Date: | 2019-10-21 09:00:47 |
Message-ID: | CAA60D55-1C62-4093-B03E-B4A12E6C55E5@yandex-team.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
> 18 окт. 2019 г., в 13:21, Dilip Kumar <dilipbalaut(at)gmail(dot)com> написал(а):
>
> On Fri, Oct 18, 2019 at 10:55 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>
>> I think we can do it in general as adding some check for parallel
>> vacuum there will look bit hackish.
> I agree with that point.
> It is not clear if we get enough
>> benefit by keeping it for cleanup phase of the index as discussed in
>> emails above. Heikki, others, let us know if you don't agree here.
>
> I have prepared a first version of the patch. Currently, I am
> performing an empty page deletion for all the cases.
I've took a look into the patch, and cannot understand one simple thing...
We should not call gistvacuum_delete_empty_pages() for same gist_stats twice.
Another way once the function is called we should somehow update or zero empty_leaf_set.
Does this invariant hold in your patch?
Best regards, Andrey Borodin.
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey Borodin | 2019-10-21 09:09:29 | Re: pglz performance |
Previous Message | Pavel Stehule | 2019-10-21 08:44:43 | Re: dropdb --force |