| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: Refactor query normalization into core query jumbling |
| Date: | 2026-04-05 22:13:40 |
| Message-ID: | CAA5RZ0vbBDPePBRD6Venpb8aW97nb37rCeT_n7htuE8L0+EjKw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> >> > I'm +-0 regarding this routine, but I can also see your point about how it's
> >> > useful to give at least the option to extensions to have a
> >> > recomputation of the Const lengths, the same way as PGSS. What are
> >> > the extensions that would use that?
> >>
> >> https://github.com/search?q=fill_in_constant_lengths&type=code
> >>
> >> A few well-known extensions/tools out there based on a Github search.
>
> FWIW, this search points to a lot of forks
>
> > See attached a v9 that extracts ComputeConstantLengths from Sami's v7
> > for easier discussion.
> >
> > I've done an updated test with pg_stat_monitor [0] and pg_tracing [1]
> > with that, and that has both extensions passing regressions tests.
> > I've also looked but not tested a third extension (sql_firewall) and
> > that looks like it should just work as well.
>
> Still I can see the gains here, so I guess that this version works
> here. I'm happy enough to see the const with JumbleState.
I took a look at v9 and it LGTM.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-04-05 22:18:28 | Re: EXPLAIN: showing ReadStream / prefetch stats |
| Previous Message | Tom Lane | 2026-04-05 22:05:41 | Re: CREATE SCHEMA ... CREATE DOMAIN support |