| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Jim Nasby <jnasby(at)upgrade(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Greg Burd <greg(at)burd(dot)me>, Robert Haas <robertmhaas(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: another autovacuum scheduling thread |
| Date: | 2026-03-24 21:12:49 |
| Message-ID: | CAA5RZ0vP3rPzSp4hYsNNhJwouaQCVOBUwGhnhOz9XpTv-6V1jw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Tue, Mar 24, 2026 at 01:32:40PM +1300, David Rowley wrote:
> > +1 for main patch first. I do think a view would be useful as a
> > follow-up. However, which columns we put in that view might have some
> > influence on how the current patch should look. I think the view
> > should show the individual scores and the total score as the Max() of
> > the individual scores. If we didn't do that, it might be confusing to
> > the user which aspect of the score the final score is derived from.
> > That might mean that it'd be better to have
> > relation_needs_vacanalyze() output the scores individually, or perhaps
> > populate a struct that we pass in that gets allocated on the stack
> > during do_autovacuum(). That'd mean a bit less churn if we go with the
> > view containing individual scores.
>
> Agreed. Here's a first try at that. I also updated the DEBUG3 at the end
> of relation_needs_vacanalyze() to show the individual scores. The comment
> above that function might need some work, and we might need a bit of
> additional commentary elsewhere.
This is good and these values could be exposed in the future view
individually. I like this.
v15 also LGTM.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-03-24 21:30:46 | Test timings are increasing too fast for cfbot |
| Previous Message | Robert Haas | 2026-03-24 21:09:51 | Re: pg_plan_advice |