| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve LWLock tranche name visibility across backends |
| Date: | 2025-08-26 22:50:34 |
| Message-ID: | CAA5RZ0v=vvzn4mvejQVA1iFabxSTUQZPDuTCAF0WqA41LKns7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
fixed the issues mentioned above in v13.
> We probably need to do the sprintf/strcpy before LWLockNewTrancheId().
> Also, I'm thinking we should just use the same tranche for both the DSA and
> the dshash table [0] to evade the DSMR_DSA_TRANCHE_SUFFIX problem, i.e.,
> those tranche names potentially require more space.
v13 also includes a separate patch for this. It removes the
DSMR_DSA_TRANCHE_SUFFIX, and dsh and dsa now use the same
user defined tranche. The tranche name is also limited to
the max length of a named tranche, MAX_NAMED_TRANCHES_NAME_LEN,
coming from lwlock.h
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0002-Tests-for-LWLock-tranche-registration-improvemen.patch | application/octet-stream | 12.9 KB |
| v13-0001-Improve-LWLock-tranche-registration.patch | application/octet-stream | 25.4 KB |
| v13-0003-Remove-the-DSA-suffix-for-tranches-created-with-.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2025-08-26 23:38:50 | Re: Generate GUC tables from .dat file |
| Previous Message | Sami Imseih | 2025-08-26 21:55:09 | Re: Per backend relation statistics tracking |