Re: test_autovacuum/001_parallel_autovacuum is broken

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniil Davydov <3danissimo(at)gmail(dot)com>
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
Date: 2026-04-09 18:32:33
Message-ID: CAA5RZ0uqvjxv5HPzz36UEq-LUf8F+kae61k0imaGw0C0XGa7nw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The root cause seems to me that it's not guaranteed that we can see
> the autovacuum logs after checking the statistics (i.e.,
> pg_stat_user_tables) as we update the statistics and then write the
> log.
>
> One way to fix the test is to replace log_contains() with
> wait_for_log(). We can also remove wait_for_autovacuum_complete()
> logic altogether.

+1. I was going to reply with exactly this. Attached is the fix.

--
Sami

Attachment Content-Type Size
v1-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch application/octet-stream 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-04-09 18:37:04 Re: POC: Parallel processing of indexes in autovacuum
Previous Message Masahiko Sawada 2026-04-09 18:25:41 Re: test_autovacuum/001_parallel_autovacuum is broken