| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add pg_stat_autovacuum_priority |
| Date: | 2026-03-30 15:32:41 |
| Message-ID: | CAA5RZ0uqVoixpgBRrge0GZY1Ofeitk3q-Rd4GrJ29W0XpVX2TQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > 0002 introduces the view with documentation and testing in
> > vacuum.c (xid age and mxid age scores are not tested as
> > they require xid_wraparound to consume enough XIDs to
> > trigger a score, which will cost too much time for a
> > regression test).
>
> After this patch, there are three copies of the combined call to
> pgstat_fetch_stat_tabentry_ext() and relation_needs_vacanalyze(). Can
> we avoid that, ideally reducing to only one such? Or, at least, it
> looks like recheck_relation_needs_vacanalyze() may no longer need to
> exist at all.
recheck_relation_needs_vacanalyze() can be removed and replace
with compute_autovac_score(). I was trying to minimize refactoring,
but this seems worthwhile to do.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-03-30 15:49:12 | Re: [PATCH] Add support for INSERT ... SET syntax |
| Previous Message | Heikki Linnakangas | 2026-03-30 15:28:58 | Re: Shared hash table allocations |