Re: Vacuumlo improvements

Hi,

sorry for the late reply.

> > DELETE FROM t WHERE lo IN (SELECT ("data")."lo_ref" FROM t_lo);
> >
> > But, this will be more comprehensive and can cover all potential ways
> > an OID or LO can be used.
> >
> > What do you think?
>
> It seems worth exploring.
>
> > But with all this done, I am not sure how much this moves the needle. It may
> > somewhat, but it's hard to tell how much. I know I have seen users store
> > LO references in text or other types, so I think we still need the
> > documentation enhancement to call out the "data loss" potential.
> >
> > I also think it will be good for the LO documentation [1] to nudge the users
> > to think about using the LO extension, as is done with the vacuumlo [2]
> > documentation.
>
> Yeah, I think we'll have to do some combination of 1) improving vacuumlo,
> 2) improving the documentation to warn users about things vacuumlo doesn't
> catch, and 3) improving the documentation to nudge users toward the lo
> extension..

See the attached patches.

0001 - vacuumlo now can recursively search for OID or LO types inside
more complex
data types. It does so by having the query return the search
expression depending on the type
to the delete statement.

0002 - adds documentation mentioning the "data loss" and to nudge
users to use vacuumlo.

--
Sami Imseih
Amazon Web Services (AWS)