| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improve explicit cursor handling in pg_stat_statements |
| Date: | 2025-06-05 12:42:48 |
| Message-ID: | CAA5RZ0uakH417UU+pZc=XB3XwA=1iPb5J-aPUdvL6xYvE478cw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> + * If an direction_keyword (i.e., FETCH FORWARD) is used, set this field
> + * to distinguish it from its numeric counterpart (i.e., FETCH 1). This
> + * value is set only within gram.y.
>
> One nitpick comment here is that I would have mentioned that this
> matters for query jumbling.
Done
> The tests can be in cursors.sql and not utility.sql, which is the test
> area for... Cursors. :D
Yeah, not sure how I missed the cursor.sql file.
> FetchDirectionKeywords could be in typedefs.list to avoid the
> indentation accident with the structure definition.
Done.
v5 attached.
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Normalize-variable-fetch-sizes-in-a-FETCH-command.patch | application/octet-stream | 14.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2025-06-05 13:24:04 | Re: pg_get_multixact_members not documented |
| Previous Message | Nitin Motiani | 2025-06-05 12:39:26 | Re: Adding pg_dump flag for parallel export to pipes |