| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, satyanarlapuram(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove autoanalyze corner case |
| Date: | 2026-04-05 22:28:06 |
| Message-ID: | CAA5RZ0uSwqD8Sh5FZ8Q0QbHqcL2+jhc78ABEoeArVdU6-13U5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > Well, autoanalyze only runs in this case if autovacuum is disabled via the
> > table's autovacuum_enabled reloption and _not_ disabled via the autovacuum
> > or track_counts GUCs. I think this is pretty clearly unintentional, as I
> > can find no mention in the code, archives, or docs. And unless I'm missing
> > something, it's completely unnecessary. So IMHO we should just remove it.
>
> +1. I think it might be better to mention this in the documentation to
> make the behavior explicit. What do you think about stating that an
> anti-wraparound autovacuum does not perform an ANALYZE, like in the
> attached patch?
+1 to the additional documentation.
a small nit: We can just say "skipped" and not "still skipped".
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-04-05 22:46:04 | Re: EXPLAIN: showing ReadStream / prefetch stats |
| Previous Message | Melanie Plageman | 2026-04-05 22:18:28 | Re: EXPLAIN: showing ReadStream / prefetch stats |