Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...)

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: m(dot)litsarev(at)postgrespro(dot)ru
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...)
Date: 2026-06-25 18:35:45
Message-ID: CAA5RZ0uCQfJDCBOcUS=_agc3hyHLHdVp-Cp+XtV2CTM_UcitkQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I don't see why we should do this at all. My earlier point about consistency is
a nice-to-have, but I don't think it's an urgent matter that we should
change all
the files, and I don't see why we should for existing pg_stat_statements calls.

It would be up to reviewers to catch this for new (or modified) error handling
and hopefully someone familiarizes themselves with
https://www.postgresql.org/docs/current/error-message-reporting.html

Others may have a different opinion.

--
Sami

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2026-06-25 18:41:49 Re: Add logical_decoding_spill_limit to cap spill file disk usage per slot
Previous Message Masahiko Sawada 2026-06-25 18:27:12 Optimize UUID parse using SIMD