| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PgStat_HashKey padding issue when passed by reference |
| Date: | 2025-09-16 19:38:20 |
| Message-ID: | CAA5RZ0uAa2e28P4K4sZWC2Oo2HS3DoF7SyQ=wcvGO+RK-pe6gw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mon, Sep 15, 2025 at 04:47:27PM -0500, Sami Imseih wrote:
> > Just to confirm, you are saying we are unlikely to ever add a new field
> > to the key. Is that correct?
>
> I would rather avoid that, yes.
7d85d87f4d5c35 added code to clear the padding bytes with memset
in anticipation that the key could be changed in the future, in a way
that padding will be introduced. So, if we are changing thoughts on
this, we should add additional comments next to
```
+ * NB: We assume that this struct contains no padding.
```
to enforce that the hash stored in objid should be used to
support additional fields, rather than adding a field directly
into the key. Will help future patch reviews/designs.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-09-16 19:46:01 | Re: GetNamedLWLockTranche crashes on Windows in normal backend |
| Previous Message | Nathan Bossart | 2025-09-16 19:35:55 | Re: GetNamedLWLockTranche crashes on Windows in normal backend |