From: | Sami Imseih <samimseih(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | David Steele <david(at)pgbackrest(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com> |
Subject: | Re: Regression in statement locations |
Date: | 2025-05-19 22:10:14 |
Message-ID: | CAA5RZ0u4wC8_fa2aHMv_wBGFVV+WK1T5ZymnHQHmAL6f0a-75Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> It is also possible that the regression is not coming from
> 499edb0 but I do not see another obvious candidate.
I used pg_stat_statements to repro the issue, and a bisect
resulted in 499edb0 being the source of the regression.
```
select pg_stat_statements_reset();
set pg_stat_statements.track='all';
DO $$
DECLARE
BEGIN
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table';
END $$;
select query from pg_stat_statements where not toplevel;
```
WITHOUT a semicolon at the end of the statements, as reported by David
```
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table';
```
I can reproduce the issue
query
-------------------------------------------------------------
CREATE TABLE do_table (weird_name INT); DROP table do_table
CREATE TABLE do_table (weird_name INT)
(2 rows)
WITH a semicolon at the end of the statements
```
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table;';
```
I cannot reproduce the issue
query
----------------------------------------
DROP table do_table
CREATE TABLE do_table (weird_name INT)
(2 rows)
I am still not sure why this is the case, but wanted to share this
for now.
--
Sami Imseih
Amazon Web Services (AWS)
From | Date | Subject | |
---|---|---|---|
Next Message | Dmitry Koval | 2025-05-19 22:35:45 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
Previous Message | Nathan Bossart | 2025-05-19 22:07:21 | Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture |