Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Date: 2025-12-11 23:55:55
Message-ID: CAA5RZ0u33MRGh3Gk1ZV8z5p3oVb0jSxXr-ojee-n0rL7Brq1hA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On a slightly related topic, I mentioned earlier that I found 3
> extensions using GetNamedDSMSegment. One of them,
> pg_track_optimizer[1] could use the new GetNamedDSHash function,
> except that it doesn't provide a callback similar to what we have in
> c, and it relies on initializing the hash in the
> callback, before it returns. That's not possible with the new
> function.
>
> What do you think, would it make sense to also include callbacks for
> GetNamedDSHash and GetNamedDSA?
>
> [1]: https://github.com/danolivo/pg_track_optimizer/

GetNamedDSA and GetNamedDSHash do not have a need for a callback,
because there isn't custom initialization logic that can be applied there.

--
Sami Imseih
Amazon Web Services (AWS)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2025-12-12 00:05:04 Re: Improve pg_sync_replication_slots() to wait for primary to advance
Previous Message Jelte Fennema-Nio 2025-12-11 23:32:24 Re: Proposal to allow setting cursor options on Portals