Re: Add support for entry counting in pgstats

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add support for entry counting in pgstats
Date: 2025-09-26 17:09:45
Message-ID: CAA5RZ0tup7ofJRg-8_PiexBC0dLeMntcw5akvU_15Qj1AVk5yQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for v3. The only remaining comment I have is:

This comment seems unnecessary, since refcount is not checked inside
pgstat_free_entry, but earlier.

+ /*
+ * Entry has been dropped with refcount at 0, hence decrement the
+ * entry counter.
+ */

I would just say this,

/* Decrement entry count, if required. */

--
Sami

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2025-09-26 17:30:09 Re: Adding REPACK [concurrently]
Previous Message David Christensen 2025-09-26 17:00:01 Re: [PATCH] GROUP BY ALL