From: | Sami Imseih <samimseih(at)gmail(dot)com> |
---|---|
To: | Nikolay Samokhvalov <nik(at)postgres(dot)ai> |
Cc: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: track generic and custom plans in pg_stat_statements |
Date: | 2025-06-03 03:31:25 |
Message-ID: | CAA5RZ0tpO_LwFNW3UJGLfK2_BNS+bgKKrKS10M1saOoGW42sKw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Now, one thing I don't like is the fact that the columns stats_since
> and minmax_stats_since
> are in between counters all of the sudden. I think we either need to
> move them to
> the front of the view, after the query field or within this patch
> move them after the
> new generic/custom plan counters. I prefer the former since we do it
> once in a major version
> and do not have to worry about it once new counters are added.
>
> It just feels odd that they sit in between the counters as they have a
> high level purpose.
It occurred to me after a bit that we added the parallel_workers_to_launch and
parallel_workers_launched fields after stats_since and minmax_stats_since
were introduced, but the stats related fields were kept at the end. So,
I will do the same with the new counters. I still don't like the stats fields
being at the end, but that could still be taken up after.
See v8 with the field names reorganized.
--
Sami Imseih
Amazon Web Services (AWS)
Attachment | Content-Type | Size |
---|---|---|
v8-0001-Add-plan_cache-counters-to-pg_stat_statements.patch | application/octet-stream | 37.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Xuneng Zhou | 2025-06-03 03:32:00 | Re: Add CHECK_FOR_INTERRUPTS in polling loop code path in XactLockTableWait |
Previous Message | Tom Lane | 2025-06-03 03:30:08 | Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them |