Re: Disallow redundant indexes

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Disallow redundant indexes
Date: 2025-04-29 17:14:45
Message-ID: CAA5RZ0tdN87n4aziJ7Tv4EFqJC4FEsM17NaC5T7yb_tE+0rbyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Apr 28, 2025 at 01:12:18PM -0500, Sami Imseih wrote:
> > If I had a dollar for every time I asked a user to check for duplicate
> > indexes :) So
> > I think it's a good idea to provide some way to detect these ( besides
> > a query in the
> > Wiki ), but I don't think we should prevent it.
> >
> > While a WARNING will be a good to have, it could easily go unnoticed,
> > but it's still good to have.
>
> I don't doubt that this is a problem in the field, but I'm not sure I'm
> convinced it's worthwhile to emit a warning that only appears for exact
> duplicates and is very easily missed, not to mention that the user could be
> intentionally creating the index.
>
>
> I don't like to idea of a new GUC to control an SQL command. The WARNING seems
> fragile because it doesn't solve the problem. I also don't want to disallow
> duplicate indexes; it can break old routines. If we want to do something about
> it, I would say let's add a psql meta command or even a new view to show
> duplicate indexes. I do think that official maintenance queries are a good to
> step forward to make life easier for DBAs.

I do think adding an annotation to the index in the \d[+] psql
meta-command will be
very useful when there are indexes that are the same except for the
name (and do
not enforce constraints?). This will at least help DBAs quickly spot
such indexes in
their tables.

--
Sami

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-04-29 17:19:18 Re: allow changing autovacuum_max_workers without restarting
Previous Message Nathan Bossart 2025-04-29 16:43:10 Re: allow changing autovacuum_max_workers without restarting