From: | Sami Imseih <samimseih(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: add function for creating/attaching hash table in DSM registry |
Date: | 2025-06-10 21:28:15 |
Message-ID: | CAA5RZ0tWrJ8SwBbqtix-qcUm30_sr2ybhDanF8iOjOX8oyYU2Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> So, if we were adding named LWLocks today, I suspect we might do it
> differently. The first thing that comes to mind is that we could store a
> shared LWLockTrancheNames table.
+1
> and stop requiring each backend to register them individually.
which will prevent odd behavior when a backend does not register
a tranche.
> In short, LWLockNewTrancheId() would gain a new name argument, and
> LWLockRegisterTranche() would disappear.
That looks sane to me. The only reason LWLockNewTrancheId and
LWLockRegisterTranche are currently separate is because each
backend has to register, so having separate routines is necessary.
> We would probably need to be
> smart to avoid contention on the name table, but that feels avoidable to
Most of the time, we would be reading and not updating the table, so
contention may not be a big problem.
--
Sami
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2025-06-10 21:44:54 | Re: CREATE DATABASE command for non-libc providers |
Previous Message | Tom Lane | 2025-06-10 21:26:46 | Re: Cleaning up historical portability baggage |