| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Track skipped tables during autovacuum and autoanalyze |
| Date: | 2026-04-22 12:49:55 |
| Message-ID: | CAA5RZ0tUHU-r=Tc47P2DZyytF7x5h5OwBiRABe_dZt+zWNqe9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the updated patch!
> I've attached a patch reflecting your comments on items 1, 2, and 5.
> As for items 3, 4, and 6, I am waiting for your comments, so the patch
> is left unchanged for now.
A few more comments:
1/
+ relid = RangeVarGetRelid(vrel->relation, NoLock, false);
Should this be called with "true" as the 3rd (missing_ok) argument, otherwise
we end up with an error instead of a "--- relation no longer exists" log. right?
2/
Can the isolation tests
src/test/isolation/specs/vacuum-skip-locked.spec be updated
to check pg_stat_user_tables as well?
3/ comment fix:
This:
* Relation could not be opened hence generate if possible a log
Should be:
* Relation could not be opened, hence generate if possible a log
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2026-04-22 13:13:21 | Re: PoC: Add condition variable support to WaitEventSetWait() |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-04-22 12:35:02 | RE: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server |