| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: track generic and custom plans in pg_stat_statements |
| Date: | 2025-05-29 18:55:39 |
| Message-ID: | CAA5RZ0t5w8mx5hb9KEFv29FFK+AScOSUuXE4raQ_pHQTFQUotw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
It turns out that 1722d5eb05d8e reverted 525392d5727f, which
made CachedPlan available in QueryDesc and thus
available to pgss_ExecutorEnd.
So now we have to make CachedPlan available to QueryDesc as
part of this change. The reason the patch was reverted is related
to a memory leak [0] in the BuildCachedPlan code and is not related
to the part that made CachedPlan available to QueryDesc.
See v6 for the rebase of the patch and addition of testing for EXPLAIN
and EXPLAIN ANALYZE which was missing from v5.
[0] https://www.postgresql.org/message-id/605328.1747710381@sss.pgh.pa.us
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-plan_cache-counters-to-pg_stat_statements.patch | application/octet-stream | 36.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dias Thomas | 2025-05-29 19:02:55 | get speed help |
| Previous Message | Tom Lane | 2025-05-29 18:30:29 | Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them |