| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: queryId constant squashing does not support prepared statements |
| Date: | 2025-05-27 23:43:01 |
| Message-ID: | CAA5RZ0t+2p-y7P_0_6-_EB0gJZtMjvSA=xspyf-aihPGwEj_mQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I've spent a bit of time looking at this, and I want to
> propose the following patchset.
Sorry about this, but I missed to add a comment in one of the
test cases for 0004 that describes the behavior of parameters
and constants that live outside of the squashed list.
The following 2 cases will result in different queryId's because
the 4th constant/parameter will be jumbled either as a type Const
or type Param.
select from tab where a in (1, 2, 3) and b = 4
select from tab where a in ($1, $2, $3) and b = $4
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0004-Support-Squashing-of-External-Parameters.patch | application/octet-stream | 13.4 KB |
| v6-0002-Enhanced-query-jumbling-squashing-tests.patch | application/octet-stream | 21.9 KB |
| v6-0003-Fix-Normalization-for-squashed-query-texts.patch | application/octet-stream | 26.4 KB |
| v6-0001-Fix-broken-normalization-due-to-duplicate-constan.patch | application/octet-stream | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2025-05-28 00:03:09 | Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer |
| Previous Message | John Naylor | 2025-05-27 23:30:48 | Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X |