| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Track skipped tables during autovacuum and autoanalyze |
| Date: | 2026-05-16 14:29:29 |
| Message-ID: | CAA5RZ0spKxhnv0vCJu6nPe7mkOqOaXh83izkuvYHHzi4emY8kA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> + INJECTION_POINT("expand-vacuum-rel-skip-locked", NULL);
> Nitpick, but now that the injection point lives inside
> pgstat_report_skipped_vacuum_analyze, it should be named accordingly.
right. I renamed it to skipped-vacuum-analyze-before-entry-lock
> Nitpick, but now that the injection point lives inside
> pgstat_report_skipped_vacuum_analyze, it should be named accordingly.
>
> + * This mirrors the approach used in pgstat_init_function_usage() for
> + * functions.
Fair. I just removed this comment. On re-reading, it really did not
add more value.
Attached v9.
Thanks!
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Track-skipped-vacuum-and-analyze-activity-per-rel.patch | application/octet-stream | 40.6 KB |
| v9-0002-Add-injection-point-test-for-vacuum-skip_locked-s.patch | application/octet-stream | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ChenhuiMo | 2026-05-16 14:32:03 | Re: [PATCH v4] Make NumericVar storage semantics explicit |
| Previous Message | Nathan Bossart | 2026-05-16 13:44:17 | Re: bump minimum supported version of psql and pg_{dump,dumpall,upgrade} to v10 |