Re: Improve LWLock tranche name visibility across backends

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve LWLock tranche name visibility across backends
Date: 2025-08-04 20:23:31
Message-ID: CAA5RZ0skN3ATpEvcFCUCiHDqvs6N95uzAo74wUSR93Bdgrq5Xg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Aug 04, 2025 at 11:32:19AM -0500, Sami Imseih wrote:
> > With a local hash table, I don't think it's necessary to introduce new
> > code for managing
> > a DSA based list of tranche names as is done in v3. We can go back to
> > storing the shared
> > trance names in dshash.
> >
> > What do you think?
>
> My first thought is that a per-backend hash table seems too
> expensive/complicated for this. Couldn't it just be an array like we have
> now?

We can, but I was considering simplicity of implementation, and using a
local hash table is slightly simpler.

That said, since we're dealing with an append-only data structure, a hash
table is probably more than we need. All we need is index-based lookup,
so I’ll go with the local array to mirror the shared ( dsa ) array.

--
Sami

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-08-04 21:11:26 Re: More protocol.h replacements this time into walsender.c
Previous Message Jim Nasby 2025-08-04 20:02:36 Re: Enable data checksums by default