| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
| Cc: | Tristan Partin <tristan(at)partin(dot)io>, bertranddrouvot(dot)pg(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param() |
| Date: | 2026-06-06 14:55:05 |
| Message-ID: | CAA5RZ0sb06bJecz1=0GtM69hO9HarCD_1+m0YOmyZ_PpEs_M6Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
good find, and thanks for the patches!
> 0001: drop the redundant initStringInfo() call (backport candidate)
This one looks like an obvious fix to me.
> 0002: allocate the static buffer once per process via
> pq_beginmessage_reuse / pq_endmessage_reuse, to avoid the
> per-call allocation (master only)
I am less convinced this will have any benefits for the additional complexity.
The callers of pgstat_progress_parallel_incr_param() are not frequent enough
to make a measurable difference here. cost delay reporting for parallel workers
is throttled by PARALLEL_VACUUM_DELAY_REPORT_INTERVAL_NS and
index progress reporting does not happen very frequently either.
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Baji Shaik | 2026-06-06 16:04:32 | Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param() |
| Previous Message | Xuneng Zhou | 2026-06-06 13:25:39 | Re: Fix race in ReplicationSlotRelease for ephemeral slots |