| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve LWLock tranche name visibility across backends |
| Date: | 2025-08-22 20:49:38 |
| Message-ID: | CAA5RZ0sUy38M2q0ML0v27hA=gZzZGdjbqv-vGyh_nd8o43Q4pA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 22, 2025 at 3:01 PM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
>
> >> If there is agreement on setting limits, may I propose
> >> 1024 tranches and NAMEDATALEN. Both seem reasonably sufficient.
>
> > Let's proceed with that approach for now. We can worry about the exact
> > limits once this is closer to commit.
>
> v11 implements the fixed size shared memory as discussed.
One point I did not make earlier is that the tranche name lengths will
need to be as long as we allow in dsm_registry.c.
```
#define DSMR_NAME_LEN 128
#define DSMR_DSA_TRANCHE_SUFFIX " DSA"
#define DSMR_DSA_TRANCHE_SUFFIX_LEN (sizeof(DSMR_DSA_TRANCHE_SUFFIX) - 1)
#define DSMR_DSA_TRANCHE_NAME_LEN (DSMR_NAME_LEN + DSMR_DSA_TRANCHE_SUFFIX_LEN)
```
We should make the limits external (in lwlock.h) and dsa_registery.c
can enforce
based on those values.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-08-22 21:33:55 | Re: Improve LWLock tranche name visibility across backends |
| Previous Message | Euler Taveira | 2025-08-22 20:32:34 | Re: Adding REPACK [concurrently] |